fix: REST-created claude panes get preallocated session identity (parity with WS lane) — fixes A13 blindness - #584

…entity plan

Stage-2 validation (12 verified, 2 falsified) of kata hbsa's plan:
- A1 falsified: predicate feed must use the parsed sessionRef locator
  presence (JSON null is absent on both doors) — Task 2 fixed, null-mint
  regression pin added
- A2 falsified: never-retired REST identity rows leave dead panes
  live-looking (session directory, rename cascade, late-signal rebind) —
  PaneIdentityBinder gains retire_pane_identity wired into the REST exit
  hook, with unit + e2e pins
- A3 caveat: failure-delete must precede the AlreadyExists 409 early-return
- A8: main.rs wiring corrected (PaneLedger constructed at :527 — hoist it)
- A12: entry-point audit settled (tabs-sync/restore deliberately deleted,
  kata h9vt); coverage map updated
- A5/A11 validation notes folded into Tasks 2-3

Full ledger: .the-usual-logs/rest-terminal-session-identity/load-bearing-ledger.md

…nc-trait dep, tracked superpowers plan premise

Fresh-eyes review iteration 1 found three blocking defects in the plan:

1. The plan claimed docs/superpowers/plans/2026-07-29-rest-terminal-session-identity.md
   was untracked and Task 8's final gate expected git status to show it
   untracked — but that file is committed on this branch (eb28b3d).
   Rewrote the Global Constraint and the Task 8 Step 4 gate to match the
   actual repo state (status must be empty).

2. Task 4 instructed copying an async-trait dependency line from
   freshell-freshagent/Cargo.toml — no crate in the workspace depends on
   async-trait (the house pattern is boxed-future aliases). Removed the
   dependency entirely.

3. Task 5 Step 4.5 instructed .await on retire_pane_identity inside the
   REST exit hook — ExitHook is a sync FnOnce on the PTY reader OS thread
   with no tokio runtime, so that step could not compile/run as written.

Joint fix for 2+3: PaneIdentityBinder is now a fully synchronous trait
(the SessionIdentityLookup precedent — every underlying registry/ledger
operation is sync). Async REST call sites hop ledger-touching calls
through awaited tokio::task::spawn_blocking (the WS create path's own
idiom, terminal.rs:2211-2234), preserving PIN 2 ordering; the exit hook
calls retire_pane_identity inline sync, exactly mirroring the WS exit
hook (terminal.rs:1334-1342). Updated trait/impl/test snippets, fake
binder, call-site snippets, file tables, and commit staging lists
accordingly (no Cargo.toml/Cargo.lock changes remain in the plan).

… surfaces (broadcast paneContent + registry rows, not REST HTTP bodies); spot-revert the mint gate, not launch_intent

… mode:claude (respawn is body-driven, empty body respawns shell); retire_pane_identity mirrors the natural-exit hook only (no retire_closed, Bound row survives natural exit)

…oth create doors

🤖 Generated with Amplifier

Co-Authored-By: Amplifier <[email protected]>

… (WS parity, kata hbsa)

Fresh POST /api/tabs {mode:"claude"} now mints a server-preallocated
session UUID via the shared freshell_platform::should_preallocate_fresh_claude
predicate (Task 1), flips the CLI launch intent to LaunchIntent::Start so
`claude --session-id <uuid>` lands in argv, and threads a
claude_fresh_prealloc flag through GatedSettleInputs for Task 5's
PIN 2-gated binder call sites (eaa25b7 symmetry).

derive_resume_identity additionally returns the pre-provider-filter
locator parse result (ledger A1: "sessionRef": null must still mint,
matching the WS door's serde Option semantics). The
tab_create_missing_session_identity warn gains an explicit
paneContent.sessionRef guard — a create that ended up with real identity
must not alarm.

Minted ids claim no D7/D8 sessionRef lease (accepted_session_ref stays
None), and REST HTTP bodies are unchanged — sessionRef surfaces on the
broadcast ui.command paneContent and the registry row.

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <[email protected]>

…entry points

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <[email protected]>

…er bridge for the REST lane

Task 4 of the REST terminal session-identity plan (kata hbsa): a synchronous
PaneIdentityBinder trait in freshell-terminal (SessionIdentityLookup's
write-side twin) and its production impl LedgerPaneIdentityBinder in
freshell-ws, mirroring the WS fresh-claude path's registry+ledger writes
(PIN2 pre-spawn binding + failure-delete, post-spawn identity/binding/
pending block) and the exit hook's retire + pending-delete hygiene.
Ledger writes are best-effort: warn and proceed, never block a create.

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <[email protected]>

…s via PaneIdentityBinder (kata hbsa)

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <[email protected]>

… swallowing them

…REST-live sessions, signal consumption (kata hbsa)

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <[email protected]>

…ding end to end

🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier)

Co-Authored-By: Amplifier <[email protected]>

…sion-identity

…r merge